fix(config): drop stale packages/ copy from base-template build#2274
Merged
Conversation
PR #2266 removed the packages/ directory in favor of the external wheels-packages registry but missed this cp line, breaking the release and snapshot workflows. The base-template scaffold no longer ships bundled packages — users install them via the registry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
develop: runs 24856392719, 24857254591, 24858357624).packages/directory in favor of the externalwheels-packagesregistry but missed the orphanedcp -r packagesline intools/build/scripts/prepare-base.sh.Copying app scaffold files...withcp: cannot stat 'packages': No such file or directory.Why the base-template no longer needs packages/
Per the Phase 1 design, packages are distributed through
wheels-dev/wheels-packagesand installed withwheels packages install <name>(4.1) orgh repo clone. They are not bundled into the starter scaffold.Test plan
bash tools/build/scripts/prepare-base.sh 4.0.0-SNAPSHOT develop 9999 falselocally — exits 0,build-wheels-base/populated.🤖 Generated with Claude Code